Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix font size of autocomplete entries after Bootstrap 5 upgrade #1310

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

osma
Copy link
Member

@osma osma commented Apr 27, 2022

Reasons for creating this PR

The font size in autocomplete entries decreased to 14px in the Bootstrap 5 upgrade due to changes in HTML structure. This PR increases it back to 16px.

Link to relevant issue(s), if any

Description of the changes in this PR

  • adjust CSS rules to match entries in autocomplete list

Known problems or uncertainties in this PR

n/a

@osma osma added the bug label Apr 27, 2022
@osma osma added this to the 2.15 milestone Apr 27, 2022
@osma osma self-assigned this Apr 27, 2022
Copy link
Collaborator

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1310 (8494b18) into master (1895bdf) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1310      +/-   ##
============================================
- Coverage     69.44%   69.38%   -0.07%     
  Complexity     1656     1656              
============================================
  Files            32       32              
  Lines          4068     4053      -15     
============================================
- Hits           2825     2812      -13     
+ Misses         1243     1241       -2     
Impacted Files Coverage Δ
model/resolver/WDQSResource.php 94.11% <0.00%> (-0.33%) ⬇️
controller/RestController.php 22.56% <0.00%> (-0.20%) ⬇️
model/sparql/JenaTextSparql.php 91.83% <0.00%> (-0.17%) ⬇️
model/sparql/GenericSparql.php 92.16% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1895bdf...8494b18. Read the comment docs.

@osma osma merged commit 863b7cb into master Apr 27, 2022
@osma osma deleted the fix-autocomplete-font-size branch April 27, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants